Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-10278: Display and parse correct date/time for "Last Login" user column #6195

Merged
merged 2 commits into from Feb 9, 2024

Conversation

runyan-co
Copy link
Contributor

@runyan-co runyan-co commented Feb 8, 2024

Issue

The "Last Login" column for the user list found in the admin dashboard was incorrectly parsing the datetime causing it to show a different date and time than when the user actually logged in.

Reproduction Steps

  1. Log in to the admin dashboard (be sure your user account has permissions to view all users).
  2. Update your timezone in your user profile to be non-UTC +0 timezone.
  3. Log out and log back in.
  4. Navigate to the user list in the admin dashboard.
  5. Sort by last logged in.
  6. Notice the date/time differences between when you logged in and the date/time it displays.

Solution

The loggedin_at attribute had to be cast to datetime in the ProcessMaker\Models\User model.

How to Test

With the fix, the correct date and time should now display for the "Last Login" column in the user listing.

CICD

ci:deploy
ci:next

Related Tickets & Packages

FOUR-10278

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

@tokensPM
Copy link

tokensPM commented Feb 8, 2024

QA server K8S was successfully deployed https://ci-1e8f732ff3.engk8s.processmaker.net

@eiresendez eiresendez self-requested a review February 8, 2024 23:54
@ryancooley ryancooley merged commit 8955888 into next Feb 9, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants