Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FOUR-13922 Configurable Requests and Tasks columns #6197

Merged
merged 3 commits into from Feb 9, 2024
Merged

FOUR-13922 Configurable Requests and Tasks columns #6197

merged 3 commits into from Feb 9, 2024

Conversation

caleeli
Copy link
Contributor

@caleeli caleeli commented Feb 8, 2024 •
edited

Configurable Requests and Tasks columns

Use edit-screens as permission to setup Requests and Tasks permissions.

Solution

  • Use edit-screens as permission to setup Requests and Tasks permissions.

How to Test

  1. Create a user with permissions:
  • edit-screens
  • view-users
  • view-groups
  1. Login the that User
  2. This User will have enabled a gear to configure the Columns of Requests and Tasks List

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy
ci:next
ci:package-savedsearch:FOUR-13922

.

@tokensPM
Copy link

tokensPM commented Feb 8, 2024

QA server K8S was successfully deployed https://ci-03f8379b37.engk8s.processmaker.net

1 similar comment
@tokensPM
Copy link

tokensPM commented Feb 9, 2024

QA server K8S was successfully deployed https://ci-03f8379b37.engk8s.processmaker.net

agustinbusso
agustinbusso reviewed Feb 9, 2024
View reviewed changes
ProcessMaker/Http/Controllers/RequestController.php
if ($defaultSavedSearch) {
$defaultColumns = SavedSearchController::adjustColumnsOf($defaultSavedSearch->columns);
if (!class_exists(SavedSearch::class)) {
$defaultSavedSearch = SavedSearch::firstSystemSearchFor(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When package is not installed is calling to SavedSearch::firstSystemSearchFor method, that method is in the package

@processmaker-sonarqube ProcessMaker SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% 0.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@tokensPM
Copy link

tokensPM commented Feb 9, 2024

QA server K8S was successfully deployed https://ci-03f8379b37.engk8s.processmaker.net

@ryancooley ryancooley merged commit 2b1a294 into next Feb 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agustinbusso agustinbusso agustinbusso left review comments

@devmiguelangel devmiguelangel devmiguelangel approved these changes

@boliviacoca boliviacoca boliviacoca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@caleeli @tokensPM @devmiguelangel @boliviacoca @agustinbusso @ryancooley