Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-14195:Launchpad carosuel does not show correct the image #6259

Merged
merged 2 commits into from Feb 22, 2024

Conversation

fagubla
Copy link
Contributor

@fagubla fagubla commented Feb 21, 2024

Issue & Reproduction Steps

If we add the scope the style defined does not apply because this is from Boostrap

Solution

  • The component does not resize the image correctly

How to Test

Go to Processes

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy
ci:next

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-cfdc13359b.engk8s.processmaker.net

@pmPaulis
Copy link
Contributor

PR related:#6254

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-cfdc13359b.engk8s.processmaker.net

Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@pmPaulis
Copy link
Contributor

@fagubla
As you know we need to tried to add a custom sytle in order to affect only this component

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-cfdc13359b.engk8s.processmaker.net

@pmPaulis
Copy link
Contributor

@fagubla
Approved it works as expected
image

@ryancooley ryancooley merged commit cc6970d into next Feb 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants