Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Existing Process Categories from Process Template Export Manifest #6293

Merged
merged 1 commit into from Feb 27, 2024

Conversation

sanjacornelius
Copy link
Contributor

@sanjacornelius sanjacornelius commented Feb 26, 2024

This PR enhances the export process to prevent redundant entries for process categories in the export process template manifest. By checking if a category already exists in the database before importing, duplicate entries are avoided, resulting in a cleaner import process.

Solution

The solution involves modifying the export process template manifest to unset the ProcessCategory dependency in the exported manifest if the category already exists in the database.

How to Test

  1. Ensure that guided templates are available in your environment by running php artisan processmaker:sync-guided-templates.
  2. Navigate to the Processes section and verify the presence of at least one existing 'Finance' category or keep track of the count of 'Finance' categories.
  3. Initiate a guided template under Processes > Guided Templates.
  4. Upon completion and redirection to the LaunchPad page of the newly created process, verify that no new 'Finance' category is created.
  5. Select the main 'Finance' category and confirm that the newly created process is listed under it.

ci:deploy

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-674a84d012.engk8s.processmaker.net

@ryancooley ryancooley merged commit 4141826 into develop Feb 27, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants