Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve 500 Error During Guided Template Execution #6301

Merged
merged 1 commit into from Feb 29, 2024

Conversation

sanjacornelius
Copy link
Contributor

Issue & Reproduction Steps

This PR addresses a 500 error encountered when running a Guided Template for the first time. The error occurred due to attempting to import the process template twice while the import process was still ongoing.

Solution

The solution introduces an importingProcess status to indicate when the process template is being imported. Before retrying the import, the system checks against this status to avoid duplicate imports.

How to Test

Note: This issue only replicated during the first run of a guided template.

  1. Ensure you have a clean instance to sync the guided templates php artisan processmaker:sync-guided-templates
  2. Navigate to Processes -> Guided Template
  3. Initiate a Guided Template process.
  4. Verify that the process runs without encountering a 500 error.
  5. Repeat the process initiation step to ensure consistent behavior across multiple attempts.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

Copy link
Contributor

@eiresendez eiresendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No 500 error occurred on the server.

Screen.Recording.2024-02-27.at.2.51.41.p.m.mov

@ryancooley ryancooley merged commit 1d6a42a into develop Feb 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants