Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-14395: Database Error: Table not found: 'project_assets' doesn't exist #6382

Merged
merged 2 commits into from Mar 14, 2024

Conversation

eiresendez
Copy link
Contributor

@eiresendez eiresendez commented Mar 11, 2024

Issue & Reproduction Steps

This error occurs when the package-projects is not installed and a non-administrator user account is used.

Solution

Currently, there is a check to determine if the projects table exists in the database schema. The proposed solution is:

  • If the projects table does not exist, then the Gate will return false by default.

The other changes are related to SonarQube.

  • The function inside the Gate had more than 4 returns
  • The before() function had the error: "Vote methods should return at least once a negative response".

How to Test

Since deploying a CI Server without the projects package is not possible, the best option for a functional test is to do it manually.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

@estebangallego estebangallego self-requested a review March 11, 2024 21:54
Copy link
Contributor

@estebangallego estebangallego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 🍾

@ryancooley ryancooley merged commit 0b6ace9 into develop Mar 14, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants