Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[35205] Permissions not applying to groups assigned to group #6440

Merged
merged 1 commit into from Mar 21, 2024

Conversation

marcoAntonioNina
Copy link
Contributor

@marcoAntonioNina marcoAntonioNina commented Mar 20, 2024

Issue & Reproduction Steps

when you have the following assignment
User1 => without permissions.
Group1 => User1 assigned to the group, and the group has permission to Create-update Users.
Group2 => Group1 assigned to the group, and the group has permission to Create-Update processes.
The user does not have all permissions assigned.

Solution

  • review recursively assigned groups.

How to Test

create
User1 => without permissions.
Group1 => User1 assigned to the group, and the group has permission to Create-update Users.
Group2 => Group1 assigned to the group, and the group has permission to Create-Update processes.

loggin with user and review permissions

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

@eiresendez eiresendez self-requested a review March 20, 2024 20:06
Copy link
Contributor

@eiresendez eiresendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! It would have been great to have a unit test! 👍

@ryancooley ryancooley merged commit e400be4 into develop Mar 21, 2024
11 of 15 checks passed
ryancooley added a commit that referenced this pull request Mar 21, 2024
[35205] Permissions not applying to groups assigned to group
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants