Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[36258 ]Interstitial pages load twice #6469

Merged
merged 2 commits into from Mar 27, 2024
Merged

[36258 ]Interstitial pages load twice #6469

merged 2 commits into from Mar 27, 2024

Conversation

marcoAntonioNina
Copy link
Contributor

@marcoAntonioNina marcoAntonioNina commented Mar 22, 2024

Issue & Reproduction Steps

When you have a process with multiple thread levels and interstitial enabled, the interstitial is loaded twice.

Solution

  • remove event

How to Test

In order to reproduce the problem you need to add a 2 second sleep to the file
ProcessMaker/Models/ProcessRequest.php
in the notifyProcessUpdated function before sending the event.
In this way a delay is created in the sending of the events.

create a case and then derive it to check that the interstitial is not loaded twice.

note:

  1. interstitial in a single process (enable interstitial in multiple assigned tasks)
  2. interstitial in a SubProcess (multiple levels in SubProcesses and enable interstitial in multiple assigned tasks)
  3. interstitial with WebEntry (enable interstitial on multiple assigned tasks)
  4. verification in the display of tasks (activate/deactivate the interstitial in several assigned tasks)

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:screen-builder:bugfix/FOUR-14542
ci:deploy

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-b638ad6af4.engk8s.processmaker.net

@marcoAntonioNina marcoAntonioNina changed the base branch from next to develop March 22, 2024 22:04
@runyan-co
Copy link
Contributor

Related PR for screen-builder:
ProcessMaker/screen-builder#1567

Copy link

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-b638ad6af4.engk8s.processmaker.net

@ryancooley ryancooley merged commit 0915ae8 into develop Mar 27, 2024
10 of 11 checks passed
ryancooley added a commit that referenced this pull request Mar 27, 2024
[36258 ]Interstitial pages load twice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants