FOUR-15487:Phase1: Remove Analytics chart from future and existing customers in dev (QuickSight related) #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stomers in dev (QuickSight related)
Passing run #690 ↗︎
Details:
Review all test suite changes for PR #1585 ↗︎ |
|||||||||||||||
|
QA server K8S was successfully deployed https://ci-9a8ef20acc.engk8s.processmaker.net |
luNunezProcessmaker
approved these changes
May 11, 2024
ana-mauricio
requested changes
May 13, 2024
There was a problem hiding this comment.
The following observations were found :
- The sizes of the cards are different (ANALYTICS CHART height is higher)
- The Welcome user is above the avatar
- The image in Anakytics chart is not responsive
https://github.com/ProcessMaker/screen-builder/assets/21198450/c6d3ad88-a185-46a9-b369-b184886dfd94
|
QA server K8S was successfully deployed https://ci-9a8ef20acc.engk8s.processmaker.net |
ana-mauricio
approved these changes
May 13, 2024
There was a problem hiding this comment.
The WELCOME was corrected, and the others observations works as expected behavior
@fagubla
pmPaulis
requested changes
May 13, 2024
| }, | ||
| methods: { | ||
| openExternalLink() { | ||
| window.open("/package-analytics-reporting", "_blank"); | ||
| }, | ||
| verifyChart() { | ||
| this.showChart = this.graphic.name === "PM Analytics Chart" || this.graphic.name === "PM Analytics Dashboard"; |
There was a problem hiding this comment.
Please this default needs to show when the Analytics does not have any chart selected like:
fagubla
force-pushed
the
feature/FOUR-15487
branch
from
9a4f922
to
bfdfbd3
Compare
|
QA server K8S was successfully deployed https://ci-9a8ef20acc.engk8s.processmaker.net |
luNunezProcessmaker
approved these changes
May 13, 2024
luNunezProcessmaker
approved these changes
May 13, 2024
|
0.0% Coverage on New Code
0.0% Duplication on New Code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
Remove Analytics chart from future and existing customers in dev (QuickSight related)
Expected behavior:
Actual behavior:
Solution
How to Test
Test the steps above
Related Tickets & Packages
Code Review Checklist
ci:deploy
ci:next
ci:package-dynamic-ui:feature/FOUR-15487