Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project.search method does not work #121

Closed
tverbrugge-athn opened this issue Feb 20, 2018 · 3 comments
Closed

project.search method does not work #121

tverbrugge-athn opened this issue Feb 20, 2018 · 3 comments

Comments

@tverbrugge-athn
Copy link

tverbrugge-athn commented Feb 20, 2018

I tried using this wrapper's search method with no luck. I tried

project.search('Destroy death star')

after setting up the client and the project variables correctly.

@jakemmarsh
Copy link

jakemmarsh commented Aug 17, 2018

@tverbrugge-athn what error were you seeing? I'm currently getting a 400, Your client has issued a malformed or illegal request. That's all we know.

For now, I'm just going to use project.stories with the filter param.

@mattyohe
Copy link

The issue appears to be here:
https://github.com/dashofcode/tracker_api/blob/master/lib/tracker_api/endpoints/search.rb#L13

Unsure what the intent of the options[:body][:query] hash is, instead fixing it this way:
options[:params] = { query: query }

@forest
Copy link
Contributor

forest commented Sep 18, 2018

@mattyohe I think the intent was not to overwrite an existing body. Also, need to make sure not to overwrite existing options[:params].

Want to send a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants