fix in Ascii.terminal_artify() for PNGs with a transparent layer #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getpixel() returns an int, intead of a tuple of ints, when the from_file is a PNG with a transparency layer. This fix creates a tuple in that case, so terminal_artify() can handle PNGs with a transparent layer.
|
Good catch with the getpixel() return problem! However it should be known that PNG images do not have layers. I get what you mean though. Would you mind sending me an image that breaks the code without this fix? I tried a PNG with transparency from Google image search and it worked. |
|
Failing pic is here http://d1vmz9r13e2j4x.cloudfront.net/NET/images/net_logo_black.png |
|
Thanks for that. I'll definitely hold onto this image for testing purposes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getpixel() returns an int, intead of a tuple of ints, when the from_pic
is a PNG with a transparency layer. This fix creates a tuple in that case,
so terminal_artify() can handle PNGs with a transparent layer.