GeoJson page after update 1.39.3 broken #734

RogueVortex · 2023-04-01T19:12:49Z

Hello.
After updating the wiki to 1.39.3 and extension maps 10.0.0, I encountered the fact that these pages of this type give an error of the following nature:

[{reqId}] {exception_url} LogicException: This ParserOutput contains no text!

Backtrace:

from /public_html/w/includes/parser/ParserOutput.php(363)
#0 /public_html/w/extensions/Maps/src/Presentation/OutputFacade.php(33): ParserOutput->getRawText()
#1 /public_html/w/extensions/Maps/src/GeoJsonPages/GeoJsonMapPageUi.php(23): Maps\Presentation\OutputFacade->addHtml()
#2 /public_html/w/extensions/Maps/src/GeoJsonPages/GeoJsonContent.php(62): Maps\GeoJsonPages\GeoJsonMapPageUi->addToOutput()
#3 /public_html/w/extensions/Maps/src/GeoJsonPages/GeoJsonContent.php(56): Maps\GeoJsonPages\GeoJsonContent->addMapHtmlToOutput()
#4 /public_html/w/includes/content/AbstractContent.php(590): Maps\GeoJsonPages\GeoJsonContent->fillParserOutput()
#5 /public_html/w/includes/content/ContentHandler.php(1883): AbstractContent->getParserOutput()
#6 /public_html/w/includes/content/ContentHandler.php(1698): ContentHandler->callDeprecatedContentGPO()
#7 /public_html/w/includes/content/Renderer/ContentRenderer.php(47): ContentHandler->getParserOutput()
#8 /public_html/w/includes/Revision/RenderedRevision.php(266): MediaWiki\Content\Renderer\ContentRenderer->getParserOutput()
#9 /public_html/w/includes/Revision/RenderedRevision.php(237): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached()
#10 /public_html/w/includes/Revision/RevisionRenderer.php(221): MediaWiki\Revision\RenderedRevision->getSlotParserOutput()
#11 /public_html/w/includes/Revision/RevisionRenderer.php(158): MediaWiki\Revision\RevisionRenderer->combineSlotOutput()
#12 [internal function]: MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}()
#13 /public_html/w/includes/Revision/RenderedRevision.php(199): call_user_func()
#14 /public_html/w/includes/poolcounter/PoolWorkArticleView.php(91): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#15 /public_html/w/includes/poolcounter/PoolWorkArticleView.php(72): PoolWorkArticleView->renderRevision()
#16 /public_html/w/includes/poolcounter/PoolCounterWork.php(162): PoolWorkArticleView->doWork()
#17 /public_html/w/includes/page/ParserOutputAccess.php(299): PoolCounterWork->execute()
#18 /public_html/w/includes/page/Article.php(714): MediaWiki\Page\ParserOutputAccess->getParserOutput()
#19 /public_html/w/includes/page/Article.php(528): Article->generateContentOutput()
#20 /public_html/w/includes/actions/ViewAction.php(78): Article->view()
#21 /public_html/w/includes/MediaWiki.php(542): ViewAction->show()
#22 /public_html/w/includes/MediaWiki.php(322): MediaWiki->performAction()
#23 /public_html/w/includes/MediaWiki.php(904): MediaWiki->performRequest()
#24 /public_html/w/includes/MediaWiki.php(562): MediaWiki->main()
#25 /public_html/w/index.php(50): MediaWiki->run()
#26 /public_html/w/index.php(46): wfIndexMain()
#27 {main}

In an attempt to solve the problem, I turned to the ParserOutput.php file and commented out the error throw, as a result, the pages started working.

public function getRawText() {
		//if ( $this->mText === null ) {
		//	throw new LogicException( 'This ParserOutput contains no text!' );
		//}

		return $this->mText;
	}

But I don't think it's a good solution, do you have any idea how to deal with it?
Thank you.

The text was updated successfully, but these errors were encountered:

RogueVortex · 2023-04-03T14:53:23Z

@JeroenDeDauw Any thoughts on how to fix this better?

JeroenDeDauw · 2023-04-03T17:13:04Z

I do not have the capacity to look into this issue at the moment

RogueVortex · 2023-04-03T17:23:45Z

I do not have the capacity to look into this issue at the moment

Okay, but I'll look forward to solving this problem)
Good luck.

RogueVortex · 2023-04-03T20:06:56Z

@JeroenDeDauw sorry for my persistence and for the fact that I tag you again.

I analyzed the changes in the current version of the wiki and found out that the default value was changed here:

/**
	 * @param string|null $text HTML. Use null to indicate that this ParserOutput contains only
	 *        meta-data, and the HTML output is undetermined, as opposed to empty. Passing null
	 *        here causes hasText() to return false. In 1.39 the default value changed from ''
	 *        to null.
	 * @param array $languageLinks
	 * @param array $categoryLinks
	 * @param bool $unused
	 * @param string $titletext
	 */
	public function __construct( $text = null, $languageLinks = [], $categoryLinks = [],
		$unused = false, $titletext = ''
	) {
		$this->mText = $text;
		$this->mLanguageLinks = $languageLinks;
		$this->mCategories = $categoryLinks;
		$this->mTitleText = $titletext;
	}

hence the called function from parseroutput returns null in this maps extension function

$this->parserOutput->getRawText()

	public function addHtml( string $html ) {
		if ( $this->outputPage !== null ) {
			$this->outputPage->addHTML( $html );
		}

		if ( $this->parserOutput !== null ) {
			$this->parserOutput->setText( $this->parserOutput->getRawText() . $html );
		}
	}

when I converted the function by removing the above call, everything worked, is it possible to fix the error like this?

	public function addHtml( string $html ) {
		if ( $this->outputPage !== null ) {
			$this->outputPage->addHTML( $html );
		}

		if ( $this->parserOutput !== null ) {
			$this->parserOutput->setText( $html );
		}
	}

Thank you

D-Groenewegen · 2023-05-29T12:58:06Z

I'm having the same issue (MW 1.39.2) so thanks for reporting and coming up with a solution. I don't know if there are real scenarios when $this->mText is available (maybe from caching). If so, a minor variant could be this:

	/*
	 * @param string $html
	 * @return string
	 */
	public function addHtml( string $html ) {
		if ( $this->outputPage !== null ) {
			$this->outputPage->addHTML( $html );
		}

		if ( $this->parserOutput !== null ) {
			$rawText = ( isset( $this->mText ) && $this->mText !== null ) ? $this->parserOutput->getRawText() : '';
			$this->parserOutput->setText( $rawText . $html );
		}
	}

krabina · 2023-09-25T09:37:43Z

@RogueVortex and @D-Groenewegen do you have plans to come up with a PR for this? I am having the same issue and a PR wold be easier to test.

RogueVortex · 2023-09-25T10:11:24Z

@RogueVortex and @D-Groenewegen do you have plans to come up with a PR for this? I am having the same issue and a PR wold be easier to test.

I'm not competent enough in this matter

redheadkelly · 2023-09-25T19:43:47Z

Having the same issue with MediaWiki 1.39.4 and Maps 10.

D-Groenewegen · 2023-10-08T09:33:31Z

Sorry, I have not been in the loop on what's happening on Github lately, but I will look into it.

D-Groenewegen · 2023-10-15T14:46:13Z

P.S. Okay so the issue was already fixed in master in February this year. We just haven't seen a new release of Maps since Oct. 2022. What would it take to release a new version, even a minor fixes-only one, maybe in time for the next SMWCon?

If you can't wait for this, just head to Maps/src/Presentation/OutputFacade.php > addHtml

and replace

$this->parserOutput->setText( $this->parserOutput->getRawText() . $html );

with

$existingText = $this->parserOutput->hasText() ? $this->parserOutput->getRawText() : '';
$this->parserOutput->setText( $existingText . $html );

JeroenDeDauw · 2023-10-15T14:51:05Z

You can help me make the release by adding the user-relevant changes to the release notes at https://github.com/ProfessionalWiki/Maps/blob/master/RELEASE-NOTES.md

redheadkelly · 2023-10-15T21:52:03Z

Curious if there is any progress on the NLS map layer that might be included in the next release?

…

On Oct 15, 2023, at 7:51 AM, Jeroen De Dauw ***@***.***> wrote: You can help me make the release by adding the user-relevant changes to the release notes at https://github.com/ProfessionalWiki/Maps/blob/master/RELEASE-NOTES.md — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.

krabina · 2023-10-17T16:33:28Z

I upgraded to "dev-master" in composer. Maps shows as version 10.1.0, but the problem still persists. The GeoJson: namespace results in errors.

[2058836af5ee24e2f81e0c87] /GeoJson:Wasserleitungen GeoJson\Exception\UnserializationException: GeoJson expected value of type array or object, null given

Backtrace:

from /vendor/jmikola/geojson/src/Exception/UnserializationException.php(24)
#0 /vendor/jmikola/geojson/src/GeoJson.php(77): GeoJson\Exception\UnserializationException::invalidValue()
#1 /extensions/Maps/src/GeoJsonPages/Semantic/SubObjectBuilder.php(21): GeoJson\GeoJson::jsonUnserialize()
#2 /extensions/Maps/src/GeoJsonPages/Semantic/SemanticGeoJsonStore.php(29): Maps\GeoJsonPages\Semantic\SubObjectBuilder->getSubObjectsFromGeoJson()
#3 /extensions/Maps/src/GeoJsonPages/GeoJsonContentHandler.php(49): Maps\GeoJsonPages\Semantic\SemanticGeoJsonStore->storeGeoJson()
#4 /includes/content/ContentHandler.php(1721): Maps\GeoJsonPages\GeoJsonContentHandler->fillParserOutput()
#5 /includes/content/Renderer/ContentRenderer.php(47): ContentHandler->getParserOutput()
#6 /includes/Revision/RenderedRevision.php(266): MediaWiki\Content\Renderer\ContentRenderer->getParserOutput()
#7 /includes/Revision/RenderedRevision.php(237): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached()
#8 /includes/Revision/RevisionRenderer.php(221): MediaWiki\Revision\RenderedRevision->getSlotParserOutput()
#9 /includes/Revision/RevisionRenderer.php(158): MediaWiki\Revision\RevisionRenderer->combineSlotOutput()
#10 [internal function]: MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}()
#11 /includes/Revision/RenderedRevision.php(199): call_user_func()
#12 /includes/poolcounter/PoolWorkArticleView.php(91): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#13 /includes/poolcounter/PoolWorkArticleView.php(72): PoolWorkArticleView->renderRevision()
#14 /includes/poolcounter/PoolCounterWork.php(162): PoolWorkArticleView->doWork()
#15 /includes/page/ParserOutputAccess.php(299): PoolCounterWork->execute()
#16 /includes/page/Article.php(714): MediaWiki\Page\ParserOutputAccess->getParserOutput()
#17 /includes/page/Article.php(528): Article->generateContentOutput()
#18 /includes/actions/ViewAction.php(78): Article->view()
#19 /includes/MediaWiki.php(542): ViewAction->show()
#20 /includes/MediaWiki.php(322): MediaWiki->performAction()
#21 /includes/MediaWiki.php(904): MediaWiki->performRequest()
#22 /includes/MediaWiki.php(562): MediaWiki->main()
#23 /index.php(50): MediaWiki->run()
#24 /index.php(46): wfIndexMain()
#25 {main}

D-Groenewegen · 2023-10-17T19:06:11Z

It looks like a new issue though. When the JSON string is decoded in GeoJson::jsonUnserialize(), it doesn't appear to produce a valid output. Maybe it has something to do with the update to GeoJsonContentHandler.php in the latest version but I would need to install it somewhere to test for myself.

thomas-topway-it · 2023-10-27T09:49:08Z

see #756
and
#757 (pull request)

krabina · 2024-01-31T06:39:53Z

Can be closed IMO, since it is working now:
https://maps.extension.wiki/wiki/GeoJson:Berlin

RogueVortex added the question label Apr 1, 2023

simontaurus mentioned this issue Jun 26, 2023

Extension:Maps / GeoJSON broken OpenSemanticLab/docker-compose-osl-wiki#35

Open

simontaurus added a commit to OpenSemanticLab/Maps that referenced this issue Jul 4, 2023

fix: ProfessionalWiki#734

715ee15

thomas-topway-it mentioned this issue Oct 27, 2023

GeoJson namespace error (GeoJsonContentHandler) #756

Closed

kghbln mentioned this issue Jan 29, 2024

rebuilding data should not fail when geojson is involved SemanticMediaWiki/SemanticMediaWiki#5590

Closed

JeroenDeDauw closed this as completed Jan 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GeoJson page after update 1.39.3 broken #734

GeoJson page after update 1.39.3 broken #734

RogueVortex commented Apr 1, 2023

RogueVortex commented Apr 3, 2023 •

edited

Loading

JeroenDeDauw commented Apr 3, 2023

RogueVortex commented Apr 3, 2023

RogueVortex commented Apr 3, 2023

D-Groenewegen commented May 29, 2023

krabina commented Sep 25, 2023

RogueVortex commented Sep 25, 2023

redheadkelly commented Sep 25, 2023

D-Groenewegen commented Oct 8, 2023

D-Groenewegen commented Oct 15, 2023 •

edited

Loading

JeroenDeDauw commented Oct 15, 2023

redheadkelly commented Oct 15, 2023 via email

krabina commented Oct 17, 2023 •

edited

Loading

D-Groenewegen commented Oct 17, 2023

thomas-topway-it commented Oct 27, 2023 •

edited

Loading

krabina commented Jan 31, 2024

GeoJson page after update 1.39.3 broken #734

GeoJson page after update 1.39.3 broken #734

Comments

RogueVortex commented Apr 1, 2023

RogueVortex commented Apr 3, 2023 • edited Loading

JeroenDeDauw commented Apr 3, 2023

RogueVortex commented Apr 3, 2023

RogueVortex commented Apr 3, 2023

D-Groenewegen commented May 29, 2023

krabina commented Sep 25, 2023

RogueVortex commented Sep 25, 2023

redheadkelly commented Sep 25, 2023

D-Groenewegen commented Oct 8, 2023

D-Groenewegen commented Oct 15, 2023 • edited Loading

JeroenDeDauw commented Oct 15, 2023

redheadkelly commented Oct 15, 2023 via email

krabina commented Oct 17, 2023 • edited Loading

D-Groenewegen commented Oct 17, 2023

thomas-topway-it commented Oct 27, 2023 • edited Loading

krabina commented Jan 31, 2024

RogueVortex commented Apr 3, 2023 •

edited

Loading

D-Groenewegen commented Oct 15, 2023 •

edited

Loading

krabina commented Oct 17, 2023 •

edited

Loading

thomas-topway-it commented Oct 27, 2023 •

edited

Loading