Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also run tests with MW 1.34 and PHP 7.4 #33

Merged
merged 2 commits into from
Apr 28, 2020
Merged

Also run tests with MW 1.34 and PHP 7.4 #33

merged 2 commits into from
Apr 28, 2020

Conversation

JeroenDeDauw
Copy link
Member

No description provided.

@JeroenDeDauw
Copy link
Member Author

JeroenDeDauw commented Mar 24, 2020

Error from line 23 of /home/scrutinizer/mw/tests/phpunit/includes/TestLocalisationCache.php: Class 'Wikimedia\TestingAccessWrapper' not found

Backtrace:
#0 /home/scrutinizer/mw/includes/ServiceWiring.php(327): TestLocalisationCache->__construct(MediaWiki\Config\ServiceOptions, LCStoreNull, MediaWiki\Logger\LegacyLogger, array, MediaWiki\Languages\LanguageNameUtils)
#1 /home/scrutinizer/mw/includes/libs/services/ServiceContainer.php(458): Wikimedia\Services\ServiceContainer->{closure}(MediaWiki\MediaWikiServices)
#2 /home/scrutinizer/mw/includes/libs/services/ServiceContainer.php(427): Wikimedia\Services\ServiceContainer->createService(string)
#3 /home/scrutinizer/mw/includes/MediaWikiServices.php(671): Wikimedia\Services\ServiceContainer->getService(string)
#4 /home/scrutinizer/mw/languages/Language.php(439): MediaWiki\MediaWikiServices->getLocalisationCache()
#5 /home/scrutinizer/mw/languages/classes/LanguageEn.php(80): Language->__construct()
#6 /home/scrutinizer/mw/languages/Language.php(260): LanguageEn->__construct()
#7 /home/scrutinizer/mw/languages/Language.php(225): Language::newFromCode(string)
#8 /home/scrutinizer/mw/includes/ServiceWiring.php(163): Language::factory(string)
#9 /home/scrutinizer/mw/includes/libs/services/ServiceContainer.php(458): Wikimedia\Services\ServiceContainer->{closure}(MediaWiki\MediaWikiServices)
#10 /home/scrutinizer/mw/includes/libs/services/ServiceContainer.php(427): Wikimedia\Services\ServiceContainer->createService(string)
#11 /home/scrutinizer/mw/includes/MediaWikiServices.php(540): Wikimedia\Services\ServiceContainer->getService(string)
#12 /home/scrutinizer/mw/includes/Setup.php(801): MediaWiki\MediaWikiServices->getContentLanguage()
#13 /home/scrutinizer/mw/maintenance/doMaintenance.php(83): require_once(string)
#14 /home/scrutinizer/mw/tests/phpunit/phpunit.php(136): require(string)

@JeroenDeDauw
Copy link
Member Author

This is weird since MW 1.34 does require the package that provides this class: https://github.com/wikimedia/mediawiki/blob/REL1_34/composer.json#L78

Perhaps the used PHPUnit version is causing problems

@s7eph4n
Copy link
Contributor

s7eph4n commented Mar 24, 2020

Dunno. Works with master.
Could this be a problem with the used installation method (composer vs. download)?

Edit: Or a combination of the two?

@JeroenDeDauw JeroenDeDauw merged commit 99b3999 into master Apr 28, 2020
@JeroenDeDauw JeroenDeDauw deleted the test-mw-34 branch April 28, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants