Allow full qualified class names as component type; Also fixed some f… #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s7eph4n
reviewed
Oct 5, 2017
src/ComponentFactory.php
Outdated
| $parent = $description->parentNode; | ||
|
|
||
| if ( $parent instanceof DOMElement && $parent->hasAttribute( 'type' ) ) { | ||
| if ( class_exists( $className ) ) { |
There was a problem hiding this comment.
I really like the idea, but putting the check here may lead to the wrong class being used, e.g. for Html. There is a component Html, but also a class with that name in the root namespace.
I would propose first trying for NAMESPACE_HIERARCHY\parent\component, then NAMESPACE_HIERARCHY\component, and only as a last resort check if the class exists in the root namespace directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ormatting