Add pre-commit configuration that catches common issues with preferen…

…ce manifests (#495)

* Remove unimplemented empty dict from subkeys

* Set ProxySetting type

* Add pre-commit config

* Update to latest pre-commit hook version

* Increment modification dates

* Use pre-commit-macadmin commit hash instead of tag

* Update check-preference-manifests hook to (commit hash of) version v1.12.2

.pre-commit-config.yaml

@@ -0,0 +1,7 @@
+repos:
+  - repo: https://github.com/homebysix/pre-commit-macadmin
+    # Please use commit hash instead of tag
+    rev: c668a2da8236a983ffaa0761fbbe31f90c0f5822
+    hooks:
+      - id: check-preference-manifests
+        exclude: "^Resources/|^Manifests/ManagedPreferencesDeveloper/"

Manifests/ManagedPreferencesApplications/com.brave.Browser.plist

@@ -15,7 +15,7 @@
 	<key>pfm_interaction</key>
 	<string>combined</string>
 	<key>pfm_last_modified</key>
-	<date>2021-12-22T06:06:42Z</date>
+	<date>2021-12-23T00:31:31Z</date>
 	<key>pfm_platforms</key>
 	<array>
 		<string>macOS</string>
@@ -6369,6 +6369,8 @@ If you choose the value 'pac_script' as 'ProxyMode', the 'ProxyPacUrl' and 'Prox
 							<string>array</string>
 						</dict>
 					</array>
+					<key>pfm_type</key>
+					<string>array</string>
 				</dict>
 			</array>
 			<key>pfm_title</key>

Manifests/ManagedPreferencesApplications/com.google.Chrome.plist

@@ -15,7 +15,7 @@
 	<key>pfm_interaction</key>
 	<string>combined</string>
 	<key>pfm_last_modified</key>
-	<date>2021-12-22T06:06:42Z</date>
+	<date>2021-12-23T00:31:31Z</date>
 	<key>pfm_platforms</key>
 	<array>
 		<string>macOS</string>
@@ -6503,6 +6503,8 @@ If you choose the value 'pac_script' as 'ProxyMode', the 'ProxyPacUrl' and 'Prox
 							<string>array</string>
 						</dict>
 					</array>
+					<key>pfm_type</key>
+					<string>array</string>
 				</dict>
 			</array>
 			<key>pfm_title</key>

Manifests/ManagedPreferencesApplications/menu.nomad.NoMADPro.plist

@@ -13,7 +13,7 @@
 	<key>pfm_format_version</key>
 	<integer>1</integer>
 	<key>pfm_last_modified</key>
-	<date>2021-12-22T05:49:22Z</date>
+	<date>2021-12-23T00:31:31Z</date>
 	<key>pfm_platforms</key>
 	<array>
 		<string>macOS</string>
@@ -679,9 +679,7 @@
 					<key>pfm_name</key>
 					<string>ChangePasswordItem</string>
 					<key>pfm_subkeys</key>
-					<array>
-						<dict/>
-					</array>
+					<array/>
 					<key>pfm_title</key>
 					<string>ChangePasswordItem</string>
 					<key>pfm_type</key>