-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added MCXRedirector and Mighty Mouse payloads #102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per my comments
Manifests/ManagedPreferencesApple/com.apple.driver.AppleHIDMouse.plist
Outdated
Show resolved
Hide resolved
- Moved manifest from "ManagedPreferencesApple" to "ManifestsApple" - Meaningful titles given to each mouse button - Updated available options for buttons 3 and 4 as per previous request change.
@apizz Apologies for how long it's taken to review the changes you requested, I've tweaked the manifest so hopefully it's better now - please let me know. I've also added icons for both manifests. |
Moved from "ManagedPreferencesApple" to "ManifestsApple"
@walkintom no worries. Changes look OK, but it appears that you've done a couple more things that need to be addressed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move back to ManagedPreferencesApple
</array> | ||
<key>pfm_description</key> | ||
<string>AirPort settings</string> | ||
<key>pfm_domain</key> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting seems slight off here
<key>pfm_type</key> | ||
<string>string</string> | ||
</dict> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra space
<string>https://apple.com/macos</string> | ||
<key>pfm_documentation_url</key> | ||
<string>https://developer.apple.com</string> | ||
<key>pfm_targets</key> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like in your MCXRedirector you reordered prefs to be alphabetical, which is good. Can we do the same here, w/ a plutil -convert xml1
. Should automatically reorganize.
@apizz Yep, I'm currently trying to work out via #profilecreator-dev why the AirPort manifest ended up in this PR, it wasn't intentional, I had intended to start a new one for it. If you're happy for it to remain in this PR, I'll make the changes you requested. |
Thank you. It's likely because you're using your Github Desktop is nice now in that if you make changes in one branch but haven't committed them yet you can change to a new branch and bring those changes with you. For the purposes of this PR, you may just want to make a copy of your AirPort manifest somewhere else, revert that commit, make a new branch and add that file there. |
- MCXRedirector moved back to "ManagedPreferencesApple" - MCXAirPort formatting changes - MCXAirPort prefs alphabetised
Closed now that we're working with #184 |
No description provided.