Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit configuration that catches common issues with preference manifests #495

Merged
merged 7 commits into from
Mar 25, 2022
Merged

Add pre-commit configuration that catches common issues with preference manifests #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5d6c4e7
Remove unimplemented empty dict from subkeys
homebysix Dec 22, 2021
00a4b15
Set ProxySetting type
homebysix Dec 22, 2021
424c72e
Add pre-commit config
homebysix Dec 22, 2021
348a827
Update to latest pre-commit hook version
homebysix Dec 23, 2021
78ef2ea
Increment modification dates
homebysix Dec 23, 2021
bd607b5
Use pre-commit-macadmin commit hash instead of tag
homebysix Dec 29, 2021
2bd2b4a
Update check-preference-manifests hook to (commit hash of) version v1…
homebysix Feb 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
repos:
- repo: https://github.com/homebysix/pre-commit-macadmin
# Please use commit hash instead of tag
rev: c668a2da8236a983ffaa0761fbbe31f90c0f5822
hooks:
- id: check-preference-manifests
exclude: "^Resources/|^Manifests/ManagedPreferencesDeveloper/"
4 changes: 3 additions & 1 deletion Manifests/ManagedPreferencesApplications/com.brave.Browser.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<key>pfm_interaction</key>
<string>combined</string>
<key>pfm_last_modified</key>
<date>2021-12-22T06:06:42Z</date>
<date>2021-12-23T00:31:31Z</date>
<key>pfm_platforms</key>
<array>
<string>macOS</string>
Expand Down Expand Up @@ -6369,6 +6369,8 @@ If you choose the value 'pac_script' as 'ProxyMode', the 'ProxyPacUrl' and 'Prox
<string>array</string>
</dict>
</array>
<key>pfm_type</key>
<string>array</string>
</dict>
</array>
<key>pfm_title</key>
Expand Down
4 changes: 3 additions & 1 deletion Manifests/ManagedPreferencesApplications/com.google.Chrome.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<key>pfm_interaction</key>
<string>combined</string>
<key>pfm_last_modified</key>
<date>2021-12-22T06:06:42Z</date>
<date>2021-12-23T00:31:31Z</date>
<key>pfm_platforms</key>
<array>
<string>macOS</string>
Expand Down Expand Up @@ -6503,6 +6503,8 @@ If you choose the value 'pac_script' as 'ProxyMode', the 'ProxyPacUrl' and 'Prox
<string>array</string>
</dict>
</array>
<key>pfm_type</key>
<string>array</string>
</dict>
</array>
<key>pfm_title</key>
Expand Down
6 changes: 2 additions & 4 deletions Manifests/ManagedPreferencesApplications/menu.nomad.NoMADPro.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<key>pfm_format_version</key>
<integer>1</integer>
<key>pfm_last_modified</key>
<date>2021-12-22T05:49:22Z</date>
<date>2021-12-23T00:31:31Z</date>
<key>pfm_platforms</key>
<array>
<string>macOS</string>
Expand Down Expand Up @@ -679,9 +679,7 @@
<key>pfm_name</key>
<string>ChangePasswordItem</string>
<key>pfm_subkeys</key>
<array>
<dict/>
</array>
<array/>
<key>pfm_title</key>
<string>ChangePasswordItem</string>
<key>pfm_type</key>
Expand Down