Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic pre-commit checks on pull requests and pushes to master branch #643

Merged
merged 2 commits into from
Nov 25, 2023

Conversation

homebysix
Copy link
Collaborator

@homebysix homebysix commented Nov 19, 2023

This PR adds a GitHub Actions workflow that runs pre-commit on any files included in a pull request or push to master. This should provide useful signal to contributors if their pull request does not align with community preference manifest standards, even if the contributor doesn't have pre-commit installed or configured on their local system.

#641 should be merged before this PR, in order for this failure to be resolved:

Check Apple Preference Manifests.........................................Failed
- hook id: check-preference-manifests
- exit code: 1

Manifests/ManagedPreferencesApplications/com.vpntracker.365mac-config.plist: pfm_format_version should be 1, not 6 (https://github.com/ProfileCreator/ProfileManifests/wiki/Manifest-Format-Versions)

This Git revision corresponds to the [v1.14.0](https://github.com/homebysix/pre-commit-macadmin/releases/tag/v1.14.0) release of pre-commit-macadmin
This will provide useful indicators when a pull request does not align with the community preference manifest recommendations.
@apizz apizz self-assigned this Nov 25, 2023
@apizz
Copy link
Collaborator

apizz commented Nov 25, 2023

Thanks!

@apizz apizz merged commit c9c8a06 into ProfileCreator:master Nov 25, 2023
1 check failed
@homebysix homebysix deleted the pre-commit-automation branch November 25, 2023 05:35
apizz pushed a commit that referenced this pull request Nov 25, 2023
…nch (#643)

* Update to latest check-preference-manifests hook

This Git revision corresponds to the [v1.14.0](https://github.com/homebysix/pre-commit-macadmin/releases/tag/v1.14.0) release of pre-commit-macadmin

* Run pre-commit on all PRs and pushes to master

This will provide useful indicators when a pull request does not align with the community preference manifest recommendations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants