Skip to content
This repository has been archived by the owner on Dec 19, 2017. It is now read-only.

FIXED: inconsistency of the return value in Context._update #92

Closed
wants to merge 2 commits into from

Conversation

xtr0
Copy link
Contributor

@xtr0 xtr0 commented Sep 1, 2016

Fix "_update..then is not a function" error if update is called with unknown url when there is no 404 handler configured

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.987% when pulling b5062b8 on xtr0:fix_ctx_update into d8a5fe0 on Profiscience:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.987% when pulling 9f07792 on xtr0:fix_ctx_update into d8a5fe0 on Profiscience:master.

@caseyWebb
Copy link
Contributor

I think we still need a way to be able to differentiate between 404s and a beforeNavigateCallback that returns false.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants