RSS: Test failures and inconsistencies #1479
Labels
Comments
|
What's the rationale for dropping a built-in plugin? I'm not sure what your packaging scripts look like exactly, but the first error in the second traceback: would be why so many tests aren't being missed. That "test" package includes all the tests for Limnoria's core, i.e. stuff outside the pre-packaged plugins. |
I wasn't involved and don't have specifics, but the packaging comment notes it was causing a conflict involving libxml2 and feedparser. I don't believe that issue exists any more and would like to include RSS again, but would rather not break tests in doing so.
That makes sense as far as why so many tests go missing, but still odd that having the RSS plugin present causes the core tests to generate an exception during import. Literally the only difference between the two cases is the removal of |
|
Could you check on your end that |
Aha, that pointed me in the right direction - it wasn't! I won't go into details since it's distro-specific, but in removing the function that ran I've worked around that issue so all tests are being run again, however Test exception |
|
Try this: diff --git a/plugins/RSS/test.py b/plugins/RSS/test.py
index eab10c61b..a9e3c07c6 100644
--- a/plugins/RSS/test.py
+++ b/plugins/RSS/test.py
@@ -102,6 +102,7 @@ def testCantAddDuplicatedFeed(self):
@mock_urllib
def testRemoveAliasedFeed(self, mock):
+ mock._data = xkcd_new
try:
self.assertNotError('rss announce add http://xkcd.com/rss.xml')
self.assertNotError('rss add xkcd http://xkcd.com/rss.xml') |
|
Confirmed, that fixes it. I could have sworn I tried that, but I must have had it in the wrong spot... Thanks! |
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this issue
Jul 5, 2021
Fixes the version reported by the bot - previously would only report as 'installed on timestamp', now reports actual version. Stop removing the RSS plugin as the conflict caused by its presence no longer appears to exist. Also add upstream patch to fix broken test in RSS tests (GH#1479). Re-enable the Aka tests as issue resolved in GH#1392. Bug: progval/Limnoria#1392 Bug: progval/Limnoria#1479 Package-Manager: Portage-3.0.20, Repoman-3.0.3 Signed-off-by: Sam Jorna <wraeth@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When the RSS plugin is removed (
rm -r plugins/RSSduring unpack) and tests are run, 993 tests get run successfully:Test output without RSS
However when the RSS plugin is not removed, there is both an import error at the start of tests as well as a failure on
testRemoveAliasedFeed, and only 542 tests get run:Test output with RSS
For some reason, the import error caused by the RSS plugin being present causes a significant number of other tests to not be loaded/run, as well as there being an actual test failure in the RSS plugin. Despite the issues during tests, the RSS plugin, and the bot generally, appear to function normally.
The text was updated successfully, but these errors were encountered: