Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aka plugin tests for webui run when --no-network is selected #1392

Closed
NP-Hardass opened this issue Dec 2, 2019 · 1 comment
Closed

Aka plugin tests for webui run when --no-network is selected #1392

NP-Hardass opened this issue Dec 2, 2019 · 1 comment
Labels

Comments

@NP-Hardass
Copy link
Contributor

NP-Hardass commented Dec 2, 2019

Aka plugin tests for webui run when --no-network is selected
I think this is in error.

ERROR: testToggleWebEnable (Aka.test.AkaWebUITestCase)                                                    [4180/19447]
----------------------------------------------------------------------                                                
Traceback (most recent call last):                                                                                    
  File "/var/tmp/portage/net-irc/limnoria-20191123/work/Limnoria-master-2019-11-23-python2_7/build/lib/supybot/plugins/Aka/test.py", line 305, in setUp                                                                                     
    httpserver.startServer()                                                                                          
  File "/var/tmp/portage/net-irc/limnoria-20191123/work/Limnoria-master-2019-11-23-python2_7/build/lib/supybot/httpserver.py", line 443, in startServer                                                                                     
    server = SupyHTTPServer(address, protocol, SupyHTTPRequestHandler)                                                
  File "/var/tmp/portage/net-irc/limnoria-20191123/work/Limnoria-master-2019-11-23-python2_7/build/lib/supybot/httpserver.py", line 180, in __init__                                                                                        
    HTTPServer.__init__(self, address, callback)                                                                      
  File "/usr/lib64/python2.7/SocketServer.py", line 417, in __init__                                                  
    self.server_bind()                                                                                                
  File "/var/tmp/portage/net-irc/limnoria-20191123/work/Limnoria-master-2019-11-23-python2_7/build/lib/supybot/httpserver.py", line 187, in server_bind
    HTTPServer.server_bind(self)
  File "/usr/lib64/python2.7/BaseHTTPServer.py", line 108, in server_bind
    SocketServer.TCPServer.server_bind(self)
  File "/usr/lib64/python2.7/SocketServer.py", line 431, in server_bind
    self.socket.bind(self.server_address)
  File "/usr/lib64/python2.7/socket.py", line 228, in meth
    return getattr(self._sock,name)(*args)
error: [Errno 98] Address already in use

Are you able to confirm?

@progval
Copy link
Owner

progval commented Dec 2, 2019

--no-network means the tests won't send any network request. But it's a bug that the tests require port 8080 to be free, instead of selecting a random free port.

@progval progval added the Bug label Dec 2, 2019
jlu5 added a commit that referenced this issue Dec 15, 2019
gentoo-bot pushed a commit to gentoo/gentoo that referenced this issue Jul 5, 2021
Fixes the version reported by the bot - previously would only report as
'installed on timestamp', now reports actual version.

Stop removing the RSS plugin as the conflict caused by its presence no
longer appears to exist.  Also add upstream patch to fix broken test in
RSS tests (GH#1479).

Re-enable the Aka tests as issue resolved in GH#1392.

Bug: progval/Limnoria#1392
Bug: progval/Limnoria#1479
Package-Manager: Portage-3.0.20, Repoman-3.0.3
Signed-off-by: Sam Jorna <wraeth@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants