Don't spread props inside DomainInput

Programmer-Network · Apr 13, 2024 · 0557514 · 0557514
1 parent f5f748c
commit 0557514
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@programmer_network/yail",
-  "version": "1.0.145",
+  "version": "1.0.146",
   "description": "Programmer Network's official UI library for React",
   "author": "Aleksandar Grbic - (https://programmer.network)",
   "publishConfig": {

diff --git a/src/Components/Inputs/DomainInput/__snapshots__/DomainInput.test.tsx.snap b/src/Components/Inputs/DomainInput/__snapshots__/DomainInput.test.tsx.snap
@@ -17,12 +17,7 @@ exports[`DomainInput component > matches snapshot 1`] = `
       <input
         class="w-full cursor-pointer border-t-2 border-b-2 border-r-2 border-primary-text-color bg-transparent p-2 transition-colors focus:border-primary focus:outline-none focus:ring-transparent rounded-tr-md rounded-br-md group-hover:border-primary"
         data-testid="input"
-        domain="example.com"
-        error=""
-        hint=""
-        max="0"
         name="domainInput"
-        type="string"
         value="test"
       />
     </div>

diff --git a/src/Components/Inputs/DomainInput/index.tsx b/src/Components/Inputs/DomainInput/index.tsx
@@ -7,7 +7,7 @@ import InputHeader from "Components/Inputs/Common/InputHeader";
 import { IDomainInputProps } from "./types";
 
 const DomainInput: FC<IDomainInputProps> = props => {
-  const { domain } = props;
+  const { domain, name, value, disabled } = props;
   const [isFocused, setIsFocused] = useState(false);
 
   const handleChange = (e: ChangeEvent<HTMLInputElement>) => {
@@ -27,7 +27,7 @@ const DomainInput: FC<IDomainInputProps> = props => {
           data-testid='domain'
           className={classNames(
             "min-w-max border-2 border-primary-text-color px-4 py-2 leading-5 tracking-tighter selection:text-primary-text-color rounded-tl-md rounded-bl-md",
-            props?.domainClassName,
+            props.domainClassName,
             {
               "group-hover:border-primary": !props.disabled,
               "!border-primary !ring-transparent": isFocused
@@ -37,8 +37,10 @@ const DomainInput: FC<IDomainInputProps> = props => {
           {domain}
         </span>
         <input
-          {...props}
           data-testid='input'
+          name={name}
+          value={value}
+          disabled={disabled}
           onFocus={() => setIsFocused(true)}
           onBlur={() => setIsFocused(false)}
           className={classNames(
@@ -63,6 +65,8 @@ DomainInput.defaultProps = {
   value: "",
   hint: "",
   className: "",
+  domainClassName: "",
+  inputWrapperClassName: "",
   type: "string",
   max: 0,
   error: "",

diff --git a/src/Components/Inputs/Tiptap/extensions.ts b/src/Components/Inputs/Tiptap/extensions.ts
@@ -41,6 +41,7 @@ const headers = Heading.configure({ levels: [1, 2, 3, 4, 5, 6] }).extend({
       5: toolbarItemToClassName[TIPTAP_TOOLBAR_ITEMS.HEADING_5].classes,
       6: toolbarItemToClassName[TIPTAP_TOOLBAR_ITEMS.HEADING_6].classes
     };
+
     return [
       `h${level}`,
       mergeAttributes(this.options.HTMLAttributes, HTMLAttributes, {