[old] Feature/c light spot #1
Conversation
There was a problem hiding this comment.
One more thing - there are some files, for example Demo Cornell Box.cpp, which were changed (i think tabs were replaced with spaces or vise versa). But changing these files does not belong to the pull request in my opinion. If merge now, that in the history of that file will be a string “Add SpotLight”, but logically these files should not be affected.
I suggest to remove them from the pull request. And if those changes are still needed, add them to another pull request (e.g. “formatting code” or smth like that)
| float angle_light_ray = ray.dir.dot(m_direction); | ||
| float attenuation = 1 / (ray.t * ray.t); | ||
| float scale; | ||
| if (angle_light_ray > m_angle) { |
There was a problem hiding this comment.
Shouldn't it be
if (angle_light_ray < m_angle) { ?
There was a problem hiding this comment.
These variables are \cos of the respective angles, so the code would need to be :
if (acos(angle_light_ray) < acos(m_angle)) {
which version would you prefer ?
Added SpotLight.
Rendered Image :
