Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(backend): setup lint workflow #43

Merged
merged 9 commits into from Mar 2, 2024
Merged

ci(backend): setup lint workflow #43

merged 9 commits into from Mar 2, 2024

Conversation

xamdoo
Copy link
Contributor

@xamdoo xamdoo commented Mar 1, 2024

What change does this PR introduce?

Added backend lint workflow to automate the execution of backend linting tools on the codebase.

Why was this change needed?

This change was implemented to automate backend code quality checks and improve overall code maintainability.

Other information (screenshots)

Checklist

  • 📝 I have reviewed my code prior to submission
  • ❔ Issue number has been linked (if applicable)
  • 🧪 Tests have been added or updated (if applicable)
  • 📖 Documentation has been updated (if applicable)
  • 📸 Screenshots added (if applicable)

xamdoo and others added 5 commits March 1, 2024 13:18
@xamdoo
ci: setup backend lint workflow
9403850
@RickyC0626 @xamdoo
docs: update PR template w/ onboarding comments (#35)
29fd590 
* docs: update PR template w/ onboarding comments

* docs: remove newlines within comments

When viewed in GitHub, contributors won't mistakenly type between the
empty lines.
@RickyC0626 @xamdoo
docs: add Feature Request issue form template (#36)
d95c4ec 
* docs: initial feature request template

* docs: add issue form template for feature request
@CeeJayyy007 @xamdoo
fix(backend): fix lint parsing error in .json files (#41)
cacf0ad
@xamdoo
chore: run lint and prettier
354561d
@xamdoo xamdoo linked an issue Mar 1, 2024 that may be closed by this pull request
🚄 CI: GitHub Action to run backend linters #21
Closed
RickyC0626
RickyC0626 requested changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@RickyC0626 RickyC0626 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In package.json, can we update the lint scripts to be similar to the ones in frontend/? For example:

"lint": "eslint . && prettier --check .",
"lint:fix": "eslint --fix && prettier --write .",

.github/workflows/backend-lint.yml Outdated Show resolved Hide resolved
@xamdoo xamdoo requested a review from RickyC0626 March 2, 2024 08:12
@RickyC0626 RickyC0626 merged commit 55fac46 into dev Mar 2, 2024
5 checks passed
@RickyC0626 RickyC0626 deleted the gh-21/ci-github-action-to-run-backend-linters branch March 2, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RickyC0626 RickyC0626 RickyC0626 approved these changes

@CeeJayyy007 CeeJayyy007 CeeJayyy007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚄 CI: GitHub Action to run backend linters
3 participants
@xamdoo @RickyC0626 @CeeJayyy007