Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(setup): lerna for monorepo package versioning #56

Merged
merged 4 commits into from Mar 6, 2024

Conversation

xamdoo
Copy link
Contributor

@xamdoo xamdoo commented Mar 2, 2024

What change does this PR introduce?

This PR sets up Lerna for managing multiple packages within a single repository

Why was this change needed?

Lerna would handle shared dependencies among packages within the monorepo reducing duplication and simplifying installation

Other information (screenshots)

Checklist

  • 📝 I have reviewed my code prior to submission
  • ❔ Issue number has been linked (if applicable)
  • 🧪 Tests have been added or updated (if applicable)
  • 📖 Documentation has been updated (if applicable)
  • 📸 Screenshots added (if applicable)

@xamdoo xamdoo linked an issue Mar 2, 2024 that may be closed by this pull request
Copy link
Contributor

@RickyC0626 RickyC0626 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to update the working directories in GitHub Actions workflows too.

lerna.json Outdated Show resolved Hide resolved
RickyC0626
RickyC0626 previously approved these changes Mar 2, 2024
Copy link
Contributor

@RickyC0626 RickyC0626 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@jaysabe jaysabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we'll need to address merging conflicts before proceeding with the merge to dev.

@RickyC0626
Copy link
Contributor

RickyC0626 commented Mar 6, 2024

Since we have new updates to the original files, we probably have to move the directories to packages/ again. git mv will be helpful for those. Perhaps 1 commit for each directory, as separate PRs. After renaming we can apply the lerna changes on top.

xamdoo and others added 4 commits March 6, 2024 09:06
Co-Authored-By: xamdoo <75206869+xamdoo@users.noreply.github.com>
This is necessary for lerna to work, as it handles dependencies per
package/workspace

Co-Authored-By: xamdoo <75206869+xamdoo@users.noreply.github.com>
@RickyC0626 RickyC0626 requested a review from jaysabe March 6, 2024 14:42
Copy link
Contributor

@CeeJayyy007 CeeJayyy007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Awesome work!

@RickyC0626 RickyC0626 merged commit 3bae500 into dev Mar 6, 2024
5 checks passed
@RickyC0626 RickyC0626 deleted the gh-48/setup-lerna branch March 6, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⚙️ Setup: lerna to manage monorepo package versioning
4 participants