Wrap all active debug messages under a setting #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interaction-Framework will also need the same thing, but it doesn't already have a setting, so not sure how to best accomplish that. How important is runtime enabling/disabling debug messages in Interaction-Framework? |
BroBeansCPG
approved these changes
Jul 17, 2023
probably redundant for the end user, but perhaps handy to add a setting for future mod developers (if they exist) to help dev process |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
systemChatdebug messages if debug is not enabled, providing a more seamless experience.All components should depend on
uh60_ui, but as long as the whole pack is used, it shouldn't be a problem - and this is not the first use of the variable without the dependency.Additionally, the best way to solve all of this would be to macroize the
diag_logandsystemChat, with a macro using either this setting or CBA'sDEBUG_MODE_X(that obviously wouldn't support runtime enabling/disabling though).