Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: shrink export html with class selector #153

Merged
merged 9 commits into from
Jan 16, 2022
Merged

improve: shrink export html with class selector #153

merged 9 commits into from
Jan 16, 2022

Conversation

strear
Copy link
Contributor

@strear strear commented Jan 4, 2022

修复 #138

按照 exportutil.cpp:898 行的注释,这个组件就要重构了。

如果重构之后,可以把 HTML 文件的模板分离出来,那就很方便了

@alphagocc
Copy link
Member

你可能需要format一下.
其实这个PR是已经是被提过了(而且被合并了),见 #139
不过我个人认为这个PR质量更好

可以把 HTML 文件的模板分离出来,那就很方便了

确实,在考虑这个事情,不过还没有想好怎么做

@strear strear changed the base branch from master to refactor-html January 5, 2022 04:57
@alphagocc alphagocc merged commit bf774fe into Project-LemonLime:refactor-html Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants