Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VQVAE + Transformer inferer #242

Merged
merged 9 commits into from
Feb 13, 2023
Merged

Add VQVAE + Transformer inferer #242

merged 9 commits into from
Feb 13, 2023

Conversation

Warvito
Copy link
Collaborator

@Warvito Warvito commented Feb 11, 2023

Implements #104

@Warvito
[WIP] Add inferer
cd7b56c 
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
@Warvito
[WIP] Add sample method
4f22bd8 
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
@Warvito Warvito linked an issue Feb 11, 2023 that may be closed by this pull request
Add Transformer Inferer #104
Closed
@Warvito Warvito changed the title 104 add transformer inferer Add transformer inferer Feb 11, 2023
@Warvito Warvito changed the title Add transformer inferer Add VQVAE + Transformer inferer Feb 11, 2023
@Warvito
Add ordering and complete Inferer methods
17704c5 
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
@Warvito
Merge branch 'main' into 104-add-transformer-inferer
3f471ee 
# Conflicts:
#	generative/inferers/inferer.py
@Warvito
Update inferer
04d8f4a 
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
@Warvito
Add test_prediction_shape
dcf417e 
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
@Warvito
Add test_sample
4be6e61 
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
@Warvito Warvito marked this pull request as ready for review February 11, 2023 21:42
@Warvito Warvito added the need reviewer This PR need a reviewer label Feb 11, 2023
@marksgraham marksgraham self-requested a review February 13, 2023 19:59
marksgraham
marksgraham approved these changes Feb 13, 2023
View reviewed changes
Copy link
Collaborator

@marksgraham marksgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Some minor suggestions/changes

generative/inferers/inferer.py Outdated Show resolved Hide resolved
generative/inferers/inferer.py Outdated Show resolved Hide resolved
generative/inferers/inferer.py Show resolved Hide resolved
@Warvito
Fix comments and docstring
7fdc10c 
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
@Warvito
Remove starting_token from __call__
e5c547e 
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
@Warvito Warvito merged commit 91e9429 into main Feb 13, 2023
@Warvito Warvito deleted the 104-add-transformer-inferer branch February 17, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marksgraham marksgraham marksgraham approved these changes

Assignees
No one assigned
Labels
need reviewer This PR need a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Transformer Inferer
2 participants
@Warvito @marksgraham