Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial commit for segmentation with diffusion models #292

Merged
merged 13 commits into from
Mar 29, 2023
Merged

initial commit for segmentation with diffusion models #292

merged 13 commits into from
Mar 29, 2023

Conversation

JuliaWolleb
Copy link
Contributor

No description provided.

@JuliaWolleb JuliaWolleb linked an issue Mar 8, 2023 that may be closed by this pull request
Add tutorial about diffusion-based segmentation #191
Closed
@JuliaWolleb JuliaWolleb marked this pull request as ready for review March 16, 2023 15:07
@Warvito
Copy link
Collaborator

Warvito commented Mar 28, 2023

Hi @JuliaWolleb , just checking, I saw that you requested my review in this PR but you added a few changes after the PR on anomaly detection. The tutorial on segmentation is looking great! Would you like me to review it at this point, or is there anything else that you are planning to change?

@JuliaWolleb
Copy link
Contributor Author

Hi @Warvito
Yes I changed some things after your review of the anomaly detection tutorial (mainly the dataloader).
For now, I do not plan any further changes, so it would be great if you could review it at this point.

Thanks a lot!

@Warvito
Fix remove changes in other files
251a0ce 
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
@Warvito
Merge branch 'main' into 191-add-tutorial-about-diffusion-based-segme…
4a1e338 
…ntation
@Warvito
Reformat using black
f6f297d 
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
@Warvito
Move to image_to_image_translation
5c5d9a2 
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
@Warvito
quick fix
e43fc51
Warvito
Warvito approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@Warvito Warvito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaWolleb Thanks for adding this tutorial. It looks great! I reformatted it to use black and have the license in the top of the file. I moved it to outside anomaly detection to improve its visibility inside a new image-2-image folder

@Warvito Warvito merged commit 6c5037a into main Mar 29, 2023
@JuliaWolleb
Copy link
Contributor Author

Great, thanks a lot :)

@Warvito Warvito deleted the 191-add-tutorial-about-diffusion-based-segmentation branch March 31, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Warvito Warvito Warvito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tutorial about diffusion-based segmentation
2 participants
@JuliaWolleb @Warvito