Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change transformer number of tokens #303

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Change transformer number of tokens #303

merged 1 commit into from
Mar 13, 2023

Conversation

Warvito
Copy link
Collaborator

@Warvito Warvito commented Mar 12, 2023

Fix #301

@Warvito
Change transformer number of tokens
3336f7c 
Signed-off-by: Walter Hugo Lopez Pinaya <ianonimato@hotmail.com>
@Warvito Warvito linked an issue Mar 12, 2023 that may be closed by this pull request
num_tokens in 2d_vqvae_transformer_tutorial #301
Closed
@Warvito Warvito requested a review from Ashayp31 March 12, 2023 19:38
@Ashayp31
Copy link
Contributor

This is correct it should have been 256 + 1 for the num tokens in the Transformer. Thanks for fixing

@Ashayp31 Ashayp31 closed this Mar 13, 2023
@Warvito Warvito reopened this Mar 13, 2023
@Warvito
Copy link
Collaborator Author

Warvito commented Mar 13, 2023

Thanks @Ashayp31, I just reopened it to merge the PR instead closing it

@Warvito Warvito merged commit 57eb4c1 into main Mar 13, 2023
@Warvito Warvito mentioned this pull request Mar 17, 2023
Closed
@Warvito Warvito deleted the 301-num_tokens-in-2d_vqvae_transformer_tutorial branch March 18, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashayp31 Ashayp31 Ashayp31 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

num_tokens in 2d_vqvae_transformer_tutorial
2 participants
@Warvito @Ashayp31