Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding tutorial on 2D super resolution using lightning #365

Merged
merged 15 commits into from
May 16, 2023
Merged

Adding tutorial on 2D super resolution using lightning #365

merged 15 commits into from
May 16, 2023

Conversation

OeslleLucena
Copy link
Contributor

Working on issue #364.

@OeslleLucena OeslleLucena linked an issue Apr 6, 2023 that may be closed by this pull request
Add tutorial on 2d super resolution using lightning #364
Closed
@OeslleLucena OeslleLucena marked this pull request as ready for review April 12, 2023 14:15
marksgraham
marksgraham requested changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@marksgraham marksgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - some small changes around imports. Could you also fix formatting by running ./runtests.sh --autofix

tutorials/generative/2d_super_resolution/2d_stable_diffusion_v2_super_resolution-lightning.py Show resolved Hide resolved
tutorials/generative/2d_super_resolution/2d_stable_diffusion_v2_super_resolution-lightning.py Outdated Show resolved Hide resolved
tutorials/generative/2d_super_resolution/2d_stable_diffusion_v2_super_resolution-lightning.py Outdated Show resolved Hide resolved
tutorials/generative/2d_super_resolution/2d_stable_diffusion_v2_super_resolution-lightning.py Outdated Show resolved Hide resolved
OeslleLucena and others added 3 commits May 15, 2023 11:48
@OeslleLucena @ericspod
Update tutorials/generative/2d_super_resolution/2d_stable_diffusion_v…
5876ccd 
…2_super_resolution-lightning.ipynb

Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: Oeslle Lucena <oeslle.lucena@gmail.com>
@OeslleLucena @ericspod
Update tutorials/generative/2d_super_resolution/2d_stable_diffusion_v…
156c914 
…2_super_resolution-lightning.py

Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: Oeslle Lucena <oeslle.lucena@gmail.com>
@OeslleLucena @ericspod
Update tutorials/generative/2d_super_resolution/2d_stable_diffusion_v…
1e5e532 
…2_super_resolution-lightning.py

Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: Oeslle Lucena <oeslle.lucena@gmail.com>
OeslleLucena and others added 5 commits May 15, 2023 13:15
@OeslleLucena @ericspod
Update tutorials/generative/2d_super_resolution/2d_stable_diffusion_v…
41ce2e9 
…2_super_resolution-lightning.py

Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: Oeslle Lucena <oeslle.lucena@gmail.com>
@OeslleLucena @ericspod
Update tutorials/generative/2d_super_resolution/2d_stable_diffusion_v…
2c95dde 
…2_super_resolution-lightning.ipynb

Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: Oeslle Lucena <oeslle.lucena@gmail.com>
@OeslleLucena @ericspod
Update tutorials/generative/2d_super_resolution/2d_stable_diffusion_v…
1ccba15 
…2_super_resolution-lightning.ipynb

Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: Oeslle Lucena <oeslle.lucena@gmail.com>
@OeslleLucena @ericspod
Update tutorials/generative/2d_super_resolution/2d_stable_diffusion_v…
ee5c8ee 
…2_super_resolution-lightning.ipynb

Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: Oeslle Lucena <oeslle.lucena@gmail.com>
@OeslleLucena @ericspod
Update tutorials/generative/2d_super_resolution/2d_stable_diffusion_v…
5e82720 
…2_super_resolution-lightning.py

Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: Oeslle Lucena <oeslle.lucena@gmail.com>
@marksgraham marksgraham merged commit 798a2ef into Project-MONAI:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericspod ericspod ericspod left review comments

@marksgraham marksgraham marksgraham approved these changes

@Warvito Warvito Awaiting requested review from Warvito

@SANCHES-Pedro SANCHES-Pedro Awaiting requested review from SANCHES-Pedro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tutorial on 2d super resolution using lightning
3 participants
@OeslleLucena @marksgraham @ericspod