Added SPADE functionality on the decode call for the sample methods. #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericspod
reviewed
Dec 6, 2023
generative/inferers/inferer.py
Outdated
Comment on lines
384
to
388
| call = ( | ||
| partial(super().__call__, seg=seg) | ||
| if isinstance(diffusion_model, SPADEDiffusionModelUNet) | ||
| else super().__call__ | ||
| ) |
There was a problem hiding this comment.
Suggested change
| call = ( | |
| partial(super().__call__, seg=seg) | |
| if isinstance(diffusion_model, SPADEDiffusionModelUNet) | |
| else super().__call__ | |
| ) | |
| call = super().__call__ | |
| if isinstance(diffusion_model, SPADEDiffusionModelUNet): | |
| call = partial(call, seg=seg) |
I feel once a if-else expression is multi-line you should use an if statement instead.
marksgraham
approved these changes
Dec 6, 2023
ericspod
reviewed
Dec 6, 2023
generative/inferers/inferer.py
Outdated
Comment on lines
462
to
467
| decode = ( | ||
| partial(autoencoder_model.decode_stage_2_outputs, seg=seg) | ||
| if isinstance(autoencoder_model, SPADEAutoencoderKL) | ||
| else autoencoder_model.decode_stage_2_outputs | ||
| ) | ||
| image = decode(latent / self.scale_factor) |
marksgraham
deleted the
440-addition-of-spadeautoencoder-case-to-controlnet-and-normal-latentdiffusioninferer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added partial to SPADE autoencoder in the sample methods.