Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NifTI image reader 2D/3D #2

Closed
wyli opened this issue Jan 10, 2020 · 4 comments
Closed

NifTI image reader 2D/3D #2

wyli opened this issue Jan 10, 2020 · 4 comments
Assignees
@wyli @atbenmurray

Comments

@wyli
Copy link
Contributor

wyli commented Jan 10, 2020

No description provided.

@wyli wyli assigned atbenmurray, yanchengnv and wyli and unassigned yanchengnv Jan 10, 2020
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Jan 14, 2020

Hi @wyli ,

As you described in Slack channel that we already have this logic.
Could you please help double confirm whether the existing code is already good enough?
Thanks.

@wyli
Copy link
Contributor Author

wyli commented Jan 14, 2020

yes the code works fine. we could have a simple unit test to demonstrate this, and then close this issue.

@ericspod
Copy link
Member

I am working on a refresh of this, PR to come.

@wyli wyli mentioned this issue Jan 20, 2020
Merged
@wyli
Copy link
Contributor Author

wyli commented Jan 23, 2020

#28 resolves this issue.

@wyli wyli closed this as completed Jan 23, 2020
@brad-t-moore brad-t-moore mentioned this issue May 26, 2021
Closed
@acamargosonosa acamargosonosa mentioned this issue Nov 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wyli wyli

@atbenmurray atbenmurray

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@wyli @atbenmurray @ericspod @Nic-Ma @yanchengnv