Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeepGrow transform broken as SpatialCrop changed properties #2087

Closed
Nic-Ma opened this issue Apr 26, 2021 · 1 comment · Fixed by #2088
Closed

DeepGrow transform broken as SpatialCrop changed properties #2087

Nic-Ma opened this issue Apr 26, 2021 · 1 comment · Fixed by #2088
Assignees
@rijobro
Labels
bug Something isn't working

Comments

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Apr 26, 2021

Describe the bug
The CropTransform of DeepGrow app depends on the SpatialCrop transform, but recent PR changed it, so this line can't work anymore:
https://github.com/Project-MONAI/MONAI/blob/master/monai/apps/deepgrow/transforms.py#L481
@Nic-Ma Nic-Ma added the bug Something isn't working label Apr 26, 2021
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Apr 26, 2021

Hi @rijobro ,

Your previous PR: #1954 changed the properties of SpatialCrop transform, which is used in the DeepGrow module.
Could you please help take a look and update SpatialCrop or update DeepGrow transform?
And it's better to add 1 more unit test to cover this case in the DeepGrow tests. @SachidanandAlle

Thanks in advance.

@rijobro rijobro mentioned this issue Apr 26, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rijobro rijobro

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update box_start/end for deepgrow rijobro/MONAI
2 participants
@Nic-Ma @rijobro