update box_start/end for deepgrow

[rijobro]

Fixes #2087.

Description

Update method for getting start and stop of bounding box from slices.

Status

Ready

Types of changes

• Non-breaking change (fix or new feature that would not break existing functionality).
• New tests added to cover the changes.
• Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
• Quick tests passed locally by running ./runtests.sh --quick --unittests.
• In-line docstrings updated.
• Documentation updated, tested make html command in the docs/ folder.

[rijobro]

@Nic-Ma hopefully this addresses that issue, but I guess the code is untested as the deepgrow unit tests passed prior to these changes. Have you got example code that would previously cause an error? Hopefully we can turn a simplified version of that into a new unit test.

[Nic-Ma]

Hi @rijobro ,

Thanks very much for your quick fix!
This case only run when if np.all(np.less(current_size, self.spatial_size)), and the unit test of this transform doesn't cover it:
https://github.com/Project-MONAI/MONAI/blob/master/tests/test_deepgrow_transforms.py#L357
Could you please help add 1 case to test your PR?

Thanks in advance.

[rijobro]

The added test passes, but I'm not really sure if it's correct or not. Could you check?

[Nic-Ma]

Looks good to me.
@SachidanandAlle , could you please also help review it?

Thanks.

[SachidanandAlle]

LGTM