Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto3dseg flexibility to override inference parameters for each model in the ensemble #5817

Closed
wyli opened this issue Jan 5, 2023 · 0 comments · Fixed by #6487
Closed

auto3dseg flexibility to override inference parameters for each model in the ensemble #5817

wyli opened this issue Jan 5, 2023 · 0 comments · Fixed by #6487

Comments

@wyli
Copy link
Contributor

wyli commented Jan 5, 2023

Is your feature request related to a problem? Please describe.
it seems in the ensemble logic, pred_param should be given in a way that's compatible with all the models participating in the inference.

def __call__(self, pred_param: Optional[Dict[str, Any]] = None):
"""
Use the ensembled model to predict result.

would be great to revise the following logic to support model-specific params as well.

for algo in self.algo_ensemble:
infer_instance = algo[AlgoEnsembleKeys.ALGO]
pred = infer_instance.predict(predict_files=[file], predict_params=param)
preds.append(pred[0])

@wyli wyli closed this as completed in #6487 May 8, 2023
wyli pushed a commit that referenced this issue May 8, 2023
Fixes #5817 .

### Description

Add an optional "algo_spec_params" in the prediction parameters which
allows user to put model-specific param in it.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [x] New tests added to cover the changes.
- [x] In-line docstrings updated.
- [x] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Mingxin Zheng <18563433+mingxin-zheng@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant