Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weekly-preview workflow failing #5882

Closed
Warvito opened this issue Jan 22, 2023 · 2 comments
Closed

weekly-preview workflow failing #5882

Warvito opened this issue Jan 22, 2023 · 2 comments
Assignees
@wyli
Labels
bug Something isn't working

Comments

@Warvito
Copy link
Collaborator

Warvito commented Jan 22, 2023

Describe the bug
For the last 2 weeks, the weekly-preview workflow has failed to deploy a new pre-release for monai-weekly.
It is showing this message:

packaging: # >> PyPA publish to PyPI GHA: UNSUPPORTED GITHUB ACTION VERSION <<#L1
You are using "pypa/gh-action-pypi-publish@master". The "master" branch of this project has been sunset and will not receive any updates, not even security bug fixes. Please, make sure to use a supported version. If you want to pin to v1 major version, use "pypa/gh-action-pypi-publish@release/v1". If you feel adventurous, you may opt to use use "pypa/gh-action-pypi-publish@unstable/v1" instead. A more general recommendation is to pin to exact tags or commit shas.
@wyli wyli mentioned this issue Jan 22, 2023
Open
@wyli
Copy link
Contributor

wyli commented Jan 22, 2023 •
edited

I'm looking into this, the issue is from the dependency on MetricsReloaded github

MONAI/requirements-dev.txt

Line 55 in 2d0e021

git+https://github.com/Project-MONAI/MetricsReloaded@monai-support#egg=MetricsReloaded

MONAI/setup.cfg

Lines 136 to 137 in 2d0e021

MetricsReloaded =
MetricsReloaded @ git+https://github.com/Project-MONAI/MetricsReloaded@monai-support#egg=MetricsReloaded 

ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/        
         Invalid value for requires_dist. Error: Can't have direct dependency:  
         "MetricsReloaded @                                                     
         git+https://github.com/Project-MONAI/MetricsReloaded@monai-support#egg=
         MetricsReloaded ; extra == 'metricsreloaded'"

packaging monai requires a proper pypi release of MetricsReloaded, see also a similar issue reported pypi/warehouse#9404.

@csudre @brudfors

Project-MONAI/MetricsReloaded#35

@wyli wyli self-assigned this Jan 22, 2023
@wyli wyli added the bug Something isn't working label Jan 22, 2023
wyli added a commit to wyli/MONAI that referenced this issue Jan 23, 2023
@wyli
workaround Project-MONAI#5882
04f4f3a 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli mentioned this issue Jan 23, 2023
Merged
7 tasks
wyli added a commit that referenced this issue Jan 23, 2023
@wyli
workaround 5882 reenable weekly preview release (#5887)
86a06f3 
part of #5882 

### Description
a workaround to not installing MetricsReloaded when packaging.
once `pip install MetricsReloaded` is made available we can undo the
workaround.

workflow tested
https://github.com/Project-MONAI/MONAI/actions/runs/3984778767/jobs/6831377542

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [x] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor

wyli commented Jan 23, 2023

the auto build is working again but before releasing v1.2, we should fix Project-MONAI/MetricsReloaded#35 and uncomment the workaround:

MONAI/setup.cfg

Lines 136 to 138 in 86a06f3

# # workaround https://github.com/Project-MONAI/MONAI/issues/5882
# MetricsReloaded =
# MetricsReloaded @ git+https://github.com/Project-MONAI/MetricsReloaded@monai-support#egg=MetricsReloaded

@wyli wyli added this to the MetricsReloaded [P0 v1.2] milestone Jan 23, 2023
@wyli wyli removed this from the MetricsReloaded [P0 v1.2] milestone Mar 6, 2023
@vikashg vikashg closed this as completed Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wyli wyli

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wyli @vikashg @Warvito