-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle Specification Needs Required Packages #6959
Comments
I don't think this is a really high priority item, but we should update the metadata schema some time anyway. |
Hi @ericspod, for now, if |
The issue is that there are required packages that a bundle absolutely needs and packages that would nice to have but not strictly needed. These two aren't differentiated in the json file and I felt there should be, or we change the name to |
Signed-off-by: KumoLiu <yunl@nvidia.com>
Hi @Ericspo, I think we also need to create a new schema and update all bundles. What do you think? |
Yes we do need a new schema. I wanted to update it to try to take into account non-tensor arguments as well as arbitrary argument names. It currently isn't quite correct without so I need to do some looking into JSON schema definitions and get to that. |
What non-tensor arguments and arbitrary argument names did you refer to? |
Currently the schema allows only tensor arguments to a network's forward pass and we need to take into account other types. The initial design intent was to capture what tensor values are needed for input but to be a complete specification we need to account for other things. For outputs it might be the same thing where we need to account for more than just tensors as output, and different numbers of outputs. |
Is your feature request related to a problem? Please describe.
Bundles can be specified to depend on optional packages through the
optional_packages_version
inmetadata.json
. Some bundles may require certain packages so arequired_packages_version
may be needed, or a change in name foroptional_packages_version
.Describe the solution you'd like
Some way of specifying what packages other Pytorch, Numpy, and MONAI are needed by a bundle.
Describe alternatives you've considered
I've used
optional_packages_version
to specify needed packages but this doesn't seem adequate.The text was updated successfully, but these errors were encountered: