Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include option to set inplace=True for resnet #7653

Closed
cclaess opened this issue Apr 17, 2024 Discussed in #7651 · 1 comment · Fixed by #7749
Closed

Include option to set inplace=True for resnet #7653

cclaess opened this issue Apr 17, 2024 Discussed in #7651 · 1 comment · Fixed by #7749
Labels
Contribution wanted enhancement New feature or request Feature request

Comments

@cclaess
Copy link

cclaess commented Apr 17, 2024 •
edited
Loading

A lot of models within the MONAI framework such as ResNet use inplace operations, such as ReLU(inplace=True) or somthing like x += MPL(x), which is not allowed in distributed mode. It would be great to have a an option to set inplace operations to false to allow distributed training
@cclaess cclaess changed the title How to use MONAI ResNet with DDP Include option to set inplace=True for resnet Apr 17, 2024
@Pkaps25
Copy link
Contributor

Pkaps25 commented May 8, 2024

I can take this one.

@Pkaps25 Pkaps25 mentioned this issue May 8, 2024
Merged
7 tasks
KumoLiu pushed a commit that referenced this issue May 9, 2024
@Pkaps25
Add activation parameter to ResNet (#7749)
258f56d 
Fixes #7653 .

### Description
Includes an `act` parameter to `ResNet` and its submodules to allow for
passing the `inplace` param.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [x] New tests added to cover the changes.
- [x] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [x] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [x] In-line docstrings updated.
- [x] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Peter Kaplinsky <peterkaplinsky@gmail.com>
Co-authored-by: Peter Kaplinsky <peterkaplinsky@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Contribution wanted enhancement New feature or request Feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add activation parameter to ResNet Pkaps25/MONAI
3 participants
@Pkaps25 @cclaess @KumoLiu