-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add rand rot90 transforms and dictionary-based counterparts #106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments inline.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments inline.
Thanks.
32b084a
to
5502dde
Compare
5502dde
to
391c4a4
Compare
before a proper adaptor is in place I reckon that we go for dictionary-based wrappers around each vanilla transform. this PR's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor changes but otherwise
thanks for the online/offline discussions, @ericspod @atbenmurray @Nic-Ma @yanchengnv , I think we are making good progress here. notebly, this PR have organised
I'll update the unit tests and merge (still open to any comments/suggestions if any) |
relevant issues #72 #58
fixes #59 fixes #63
Description
adds
in vanilla and dictionary-based formats.
organises:
could you have a look?
@atbenmurray @ericspod @Nic-Ma @yanchengnv
it could be a starting point for further discussionsStatus
READY
Types of changes