Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1123 - drop torch 1.4 support #1110

Merged
merged 5 commits into from Oct 26, 2020
Merged

1123 - drop torch 1.4 support #1110

merged 5 commits into from Oct 26, 2020

Conversation

wyli
Copy link
Member

@wyli wyli commented Oct 16, 2020

Description

fixes #1123

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

.github/workflows/pythonapp.yml Outdated Show resolved Hide resolved
.github/workflows/pythonapp.yml Outdated Show resolved Hide resolved
@wyli wyli marked this pull request as draft October 21, 2020 13:24
@wyli wyli changed the title Adds torch 1.4 quick tests; fixes incompatible commands 1123 - drop torch 1.4 support Oct 21, 2020
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
This reverts commit 724fd7a.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli marked this pull request as ready for review October 24, 2020 13:23
@wyli wyli requested a review from Nic-Ma October 24, 2020 13:23
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, put several questions inline.
Thanks.

.github/workflows/cron.yml Show resolved Hide resolved
docs/requirements.txt Outdated Show resolved Hide resolved
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli merged commit b7cd830 into master Oct 26, 2020
@wyli wyli deleted the adds-torch-14-tests branch October 28, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drop pytorch 1.4 support
4 participants