Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

58-implement-transform-adaptor-2: Re-adding work via new branch as th… #143

Merged
merged 5 commits into from
Mar 6, 2020

Conversation

atbenmurray
Copy link
Contributor

@atbenmurray atbenmurray commented Mar 4, 2020

fixes #58

A re-commit of the work in question as the original branch '58-implement-transform-adaptor' has become un-rebaseable

Description

Addition of several adaptor methods that allow use of transforms from different libraries with the torchvision and monai Compose functions.

Status

Ready

Types of changes

  • New functionality
  • New tests added to cover the changes
  • Docstrings/Documentation updated

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this is not supported, not sure if it is expected:

def foo(image, *a):
    return image + 1, a

d = {'image': 2, 'a': 'test'}
dres = adaptor(foo, ('image', 'a'))(d)
print(dres)

@atbenmurray
Copy link
Contributor Author

It isn't currently supported. Can we go ahead with it now and address that subsequently?

@wyli wyli merged commit 2bda586 into master Mar 6, 2020
@wyli wyli deleted the 58-implement-transform-adaptor-2 branch April 6, 2020 13:36
wyli pushed a commit that referenced this pull request Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

58 preprocessor adaptor function for compose
2 participants