check if orig_size is list of tensors #3422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Nic-Ma
reviewed
Dec 1, 2021
| orig_size = transform[TraceKeys.ORIG_SIZE] | ||
| if isinstance(orig_size[0], torch.Tensor): | ||
| orig_size = torch.as_tensor(orig_size) | ||
| orig_size = np.asarray(orig_size) |
There was a problem hiding this comment.
Hi @rijobro ,
I think maybe you can simply use the convert_data_type utility here to convert to numpy array with wrap_sequence arg?
Thanks.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes after the dataloader,
transform[TraceKeys.ORIG_SIZE]is given as a list oftorch.Tensor. Callingnp.asarrayon this will return a numpy array containing a list (dtype=object), which causes problems. This fix will convert to a singletorch.Tensorif necessary and then convert that to a numpy array.I'm not quite sure the best way to add a test for this. I suspect all our inverses should also be run through the DataLoader, maybe with and
EnsureTypeat the end to simulate the numpy->torch conversion that we normally experience.Status
Ready
Types of changes