Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6066 pad mode #6076

Merged
merged 8 commits into from
Feb 28, 2023
Merged

6066 pad mode #6076

merged 8 commits into from
Feb 28, 2023

Conversation

wyli
Copy link
Member

@wyli wyli commented Feb 27, 2023 •
edited

Fixes #6066

Description

prefer the pytorch backend as much as possible

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
update padding mode
765cfc3 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update and tests
cf1c93a 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update
7f45545 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update
e6e16de 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Merge remote-tracking branch 'upstream/dev' into 6066-pad-mode
b2f9bd8 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli marked this pull request as ready for review February 27, 2023 19:06
Nic-Ma
Nic-Ma approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It overall looks good to me, put some minor comments inline.

Thanks.

wyli and others added 2 commits February 28, 2023 11:39
@wyli
Copy link
Member Author

wyli commented Feb 28, 2023

/build

@wyli wyli merged commit ab800d8 into Project-MONAI:dev Feb 28, 2023
@wyli wyli deleted the 6066-pad-mode branch February 28, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@KumoLiu KumoLiu KumoLiu approved these changes

@yiheng-wang-nv yiheng-wang-nv Awaiting requested review from yiheng-wang-nv

@ericspod ericspod Awaiting requested review from ericspod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pad uses numpy though pytorch backend is available
3 participants
@wyli @Nic-Ma @KumoLiu