#6094 - add warn flag to RandCropByLabelClasses
#6121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kbressem <kenobressem@gmail.com>
Signed-off-by: Keno <37253540+kbressem@users.noreply.github.com>
Signed-off-by: kbressem <kenobressem@gmail.com>
Signed-off-by: kbressem <kenobressem@gmail.com>
wyli
approved these changes
Mar 9, 2023
|
please also change the dictionary version MONAI/monai/transforms/croppad/dictionary.py Line 895 in b85e2c6 |
Signed-off-by: kbressem <kenobressem@gmail.com>
|
/build |
7 tasks
wyli
pushed a commit
that referenced
this pull request
Mar 11, 2023
Avoids crashing of the function if `ratios_[i] = 0` cannot be updated Fixes #6121 ### Description Adds additional if statement to check if warn is true, so that the following code can still be executed. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: kbressem <kenobressem@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6094.
Description
Adds the
warnflag toRandCropByLabelClasses. IfTruethe behavior of the class remains unchanged. IfFalsethe function will not print a warning if a class is not present in the label.Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.