Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6136 6146 update the default writer flag #6147

Merged
merged 13 commits into from
Mar 16, 2023
Merged

6136 6146 update the default writer flag #6147

merged 13 commits into from
Mar 16, 2023

Conversation

wyli
Copy link
Member

@wyli wyli commented Mar 14, 2023

Fixes #6136
fixes #6146

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
update the default flag
e3082b7 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli changed the title 6136 update the default writer flag 6136 6146 update the default writer flag Mar 14, 2023
@wyli wyli marked this pull request as ready for review March 15, 2023 00:14
KumoLiu
KumoLiu reviewed Mar 15, 2023
View reviewed changes
monai/data/image_writer.py Outdated Show resolved Hide resolved
@wyli
Merge remote-tracking branch 'upstream/dev' into 6136-itk-writer
071b556 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update based on comments
2a4cb8d 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update channel_dim None case
b0ca392 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update docstring
ff22420 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Merge remote-tracking branch 'upstream/dev' into 6136-itk-writer
45e118b 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update docstrings
a7888cd 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested review from ericspod and KumoLiu and removed request for ericspod March 15, 2023 17:21
@wyli
fixes codeqltests
8676c55 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
KumoLiu
KumoLiu approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing, LGTM.

@wyli
Merge remote-tracking branch 'upstream/dev' into 6136-itk-writer
805a255 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
KumoLiu
KumoLiu reviewed Mar 16, 2023
View reviewed changes
monai/data/image_writer.py Outdated Show resolved Hide resolved
@wyli
update based on comments
e06d8ea 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update tests
d9aaa7e 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
adds verified integration answers
a7b889f 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
workaround Project-MONAI#6155
dd31ea2 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Member Author

wyli commented Mar 16, 2023

/build

@wyli wyli enabled auto-merge (squash) March 16, 2023 18:09
@wyli wyli merged commit 66d0478 into Project-MONAI:dev Mar 16, 2023
@wyli wyli deleted the 6136-itk-writer branch March 25, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KumoLiu KumoLiu KumoLiu approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

@yiheng-wang-nv yiheng-wang-nv Awaiting requested review from yiheng-wang-nv

@ericspod ericspod Awaiting requested review from ericspod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@wyli @ericspod @Nic-Ma @KumoLiu