Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix channel_dim bug in TiffFileWSIReader and CuCIMWSIReader #6514

Merged
merged 3 commits into from
May 12, 2023
Merged

Fix channel_dim bug in TiffFileWSIReader and CuCIMWSIReader #6514

merged 3 commits into from
May 12, 2023

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented May 12, 2023

Fixes #6511 .

Description

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@KumoLiu
fix Project-MONAI#6511
e022915 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
update unittests
5dbd100 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu KumoLiu mentioned this pull request May 12, 2023
Closed
@KumoLiu
fix flake8
8c0b6be 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu KumoLiu requested review from Nic-Ma, wyli and drbeh May 12, 2023 08:17
@wyli
Copy link
Member

wyli commented May 12, 2023

/build

@wyli wyli enabled auto-merge (squash) May 12, 2023 09:39
@wyli wyli merged commit d421efc into Project-MONAI:dev May 12, 2023
34 of 37 checks passed
@KumoLiu KumoLiu deleted the update_wsi_reader branch May 15, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

@drbeh drbeh Awaiting requested review from drbeh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug for changing channel_dim in Whole slide image reader
2 participants
@KumoLiu @wyli