Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6555 fixes integration issues #6615

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Conversation

wyli
Copy link
Member

@wyli wyli commented Jun 14, 2023

Fixes #6555

Description

Absolute differences such as 4.26173210144043e-06 in test_onnx_save looks ok, this increases the tolerances. otherwise we randomly run into integration errors because of the checks.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli marked this pull request as ready for review June 14, 2023 08:57
@wyli
Copy link
Member Author

wyli commented Jun 14, 2023

/build

@wyli wyli enabled auto-merge (squash) June 14, 2023 09:14
@wyli wyli merged commit a89a0af into Project-MONAI:dev Jun 14, 2023
32 of 37 checks passed
@wyli wyli deleted the 6555-integration-test branch June 20, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_retinanet onnx
2 participants