Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add end_lr in WarmupCosineSchedule #6662

Merged
merged 3 commits into from
Jun 27, 2023
Merged

Add end_lr in WarmupCosineSchedule #6662

merged 3 commits into from
Jun 27, 2023

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Jun 27, 2023

Fixes #6527 .

Description

Add end_lr in WarmupCosineSchedule

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@KumoLiu
fix Project-MONAI#6527
86e1708 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
add unittests
7c6ddb5 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
Merge branch 'dev' of https://github.com/Project-MONAI/MONAI into add…
b437a6b 
…-end-lr
@KumoLiu KumoLiu requested review from wyli and ericspod June 27, 2023 09:05
wyli
wyli approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli
Copy link
Member

wyli commented Jun 27, 2023

/build

@wyli wyli enabled auto-merge (squash) June 27, 2023 09:43
@wyli wyli merged commit 60620e4 into Project-MONAI:dev Jun 27, 2023
30 of 35 checks passed
@KumoLiu KumoLiu deleted the add-end-lr branch June 27, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@ericspod ericspod Awaiting requested review from ericspod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WarmupCosineSchedule add end_lr
2 participants
@KumoLiu @wyli