Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default val for config parsed content #6756

Merged
merged 3 commits into from
Jul 26, 2023
Merged

default val for config parsed content #6756

merged 3 commits into from
Jul 26, 2023

Conversation

wyli
Copy link
Member

@wyli wyli commented Jul 21, 2023

Fixes #6755

Description

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli requested review from ericspod, Nic-Ma and KumoLiu July 21, 2023 20:31
@wyli
default val for config parsed
55e6c2e 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
KumoLiu
KumoLiu approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, LGTM.

wyli added 2 commits July 26, 2023 07:06
@wyli
Merge remote-tracking branch 'upstream/dev' into config_default
2fbb35e 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
smaller tests
3b2b387 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli enabled auto-merge (squash) July 26, 2023 06:12
@wyli
Copy link
Member Author

wyli commented Jul 26, 2023

/build

@wyli wyli merged commit 3b56e7f into Project-MONAI:dev Jul 26, 2023
33 of 37 checks passed
@wyli wyli deleted the config_default branch July 27, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KumoLiu KumoLiu KumoLiu approved these changes

@ericspod ericspod Awaiting requested review from ericspod

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get parsed content with default attribute error
2 participants
@wyli @KumoLiu